Support sharing connection pool client. #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code currently does not allow you to set the external MongoDb client for re-use. A simple modification to this code would help utilize the external connection pool client
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 85af6a9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #694 +/- ##
===========================================
- Coverage 100.00% 98.52% -1.48%
===========================================
Files 1 2 +1
Lines 76 136 +60
Branches 15 32 +17
===========================================
+ Hits 76 134 +58
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
|
thanks for the PR will merge |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code currently does not allow you to set the external MongoDb client for re-use. A simple modification to this code would help utilize the external connection pool client